Tuesday, April 27, 2010

Solving design issue

SO far the code worked really well as expected, then we created patches and submitted them. (by the way he create patches option is pretty cool, it helps to see the changes you made, and you may not even remember). Ben Wolfe suggested that we move the javascript that control the pop-up preview from the "encounterDisplay.jsp" file so that PreviewComplexObstag class would have its own built-in js; which would make the take more reusable. We solved this by correcting the css class, instead. Also we move the resize method from PreviewComplexObstag class to ImageHandler, which made more sense in the design prospective.

No comments:

Post a Comment